feat(toolset): inherit feedback from MCP, add disable flag#191
Draft
willleeney wants to merge 2 commits into
Draft
feat(toolset): inherit feedback from MCP, add disable flag#191willleeney wants to merge 2 commits into
willleeney wants to merge 2 commits into
Conversation
The StackOne MCP server now exposes submit_feedback as a global tool on every account, so the SDK inherits it from the catalog instead of defining its own. fetch_tools now: - keeps submit_feedback available by default even when providers/actions filters are applied (those are connector-keyed and would otherwise drop the connector-less feedback tool), - collapses it to a single instance across multi-account fetches, - drops it only when feedback=False is passed. Removes the standalone create_feedback_tool / FeedbackTool (which POSTed to the removed /ai/tool-feedback endpoint) and its tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
_build_tools now appends the global submit_feedback tool (pulled from the same cached MCP catalog fetch it already does for connector discovery) so search-and-execute agents inherit feedback too. Gated by a feedback flag (default True) mirroring fetch_tools. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The StackOne MCP server now exposes
submit_feedbackas a global tool on every account (see unified-cloud-api PR #8507). The SDK inherits it straight from the MCP catalog (fetch_toolsalready lists from/mcp) and executes it through the same/actions/rpcpath as every other tool — it no longer defines its own feedback tool.create_feedback_tool/FeedbackTool(which POSTed to the now-removed/ai/tool-feedback) and its tests.fetch_toolskeepssubmit_feedbackavailable even whenproviders/actionsfilters are applied (those are connector-keyed and would drop it), collapses it to a single instance across multi-account fetches, and removes it only whenfeedback=Falseis passed.unified-cloud-api PR #8507 (global
submit_feedbackMCP tool +/actions/rpcdispatch). Draft until that merges — executing feedback 404s until then.Test plan
tests/test_feedback_tool.pypatches the MCP fetch so it doesn't depend on the vendored node mock: on-by-default,feedback=Falsedisables, survives provider filter, single instance across accounts.ruffclean.vendor/stackone-ai-nodesubmodule) only gainssubmit_feedbackonce bumped to the matching node release; when that happens, the existingtest_fetch_toolsintegration count assertions will each need +1 for the inherited feedback tool.🤖 Generated with Claude Code
Summary by cubic
Inherit the global
submit_feedbackMCP tool across all accounts and remove the custom feedback tool. It’s included by default in bothfetch_toolsand search-and-execute builds, and can be disabled withfeedback=False.New Features
submit_feedback; executed via/actions/rpc.fetch_tools(feedback=False)to omit; kept regardless ofproviders/actions, single instance across multi-account fetches._build_tools(feedback=False)now appendssubmit_feedbackto the search/execute meta tools by default (sourced from the same cached catalog).Migration
create_feedback_toolandFeedbackTool(and/ai/tool-feedback). Usesubmit_feedbackfromfetch_tools()or via the default search/execute set.Written for commit 0181d05. Summary will update on new commits.